Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some private class properties not settable #15527

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Make some private class properties not settable #15527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1359217
Make SingleColumnFrame._column not settable
mroeschke Apr 12, 2024
220f0a5
Dont make .categories settable
mroeschke Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions python/cudf/cudf/core/column/categorical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,12 +614,6 @@ def children(self) -> Tuple[NumericalColumn]:
def categories(self) -> ColumnBase:
return self.dtype.categories._values

@categories.setter
def categories(self, value):
self._dtype = CategoricalDtype(
categories=value, ordered=self.dtype.ordered
)

@property
def codes(self) -> NumericalColumn:
if self._codes is None:
Expand Down
5 changes: 0 additions & 5 deletions python/cudf/cudf/core/single_column_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,6 @@ def _num_columns(self):
def _column(self):
return self._data[self.name]

@_column.setter # type: ignore
@_cudf_nvtx_annotate
def _column(self, value):
self._data[self.name] = value

@property # type: ignore
@_cudf_nvtx_annotate
def values(self): # noqa: D102
Expand Down
Loading