Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some private class properties not settable #15527

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Make some private class properties not settable #15527

merged 2 commits into from
Apr 15, 2024

Conversation

mroeschke
Copy link
Contributor

Description

It appears these properties do not map to public APIs, and for better state management, these @propertys are better left not settable.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 12, 2024
@mroeschke mroeschke requested a review from a team as a code owner April 12, 2024 23:54
@mroeschke mroeschke requested review from bdice and isVoid April 12, 2024 23:54
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 64229b9 into rapidsai:branch-24.06 Apr 15, 2024
70 checks passed
@mroeschke mroeschke deleted the ref/props/no_setting branch April 15, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @bdice