This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Update go mod tidy (and fix for Azure/go-autorest & azure-sdk-for-go) #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, still conflicting/faliing |
We have dependencies that depend on pre-module versions of the azure go-autorest client. This causes ambiguous import errors in go1.13. We should remove the replace directive when we upgrade our dependencies.
StrongMonkey
approved these changes
Sep 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix similar to that from coredns/coredns#3258
This fix can be dropped once our dependencies are updated to a more recent version of the
Azure/go-autorestNote: This only occurs with
go mod tidyon go1.13