Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go mod tidy (and fix for Azure/go-autorest & azure-sdk-for-go) #3258

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Update go mod tidy (and fix for Azure/go-autorest & azure-sdk-for-go) #3258

merged 1 commit into from
Sep 6, 2019

Conversation

yongtang
Copy link
Member

@yongtang yongtang commented Sep 6, 2019

See #3209 (comment) for the previous issues, also see Azure/go-autorest#414 for some further background.

Basically go mod has some issue when multiple tags exist (as main module and submodule) within the same repo. That was fixed in go-autorest very recently, though azure-sdk-for-go has not been fully updated yet.

This fix is a temporarily one with replace fix. Once azure-sdk-for-go is updated then we could drop the replace fix

Signed-off-by: Yong Tang yong.tang.github@outlook.com

@yongtang
Update go mod tidy (and fix for Azure/go-autorest & azure-sdk-for-go)
e15f1bb 
See #3209 (comment)
for the previous issues, also see Azure/go-autorest#414
for some further background.

Basically go mod has some issue when multiple tags exists (as main module and submodule)
within the same repo. That was fixed in go-autorest very recently, though
azure-sdk-for-go has not been fully updated yet.

This fix is a temporarily one with `replace` fix. Once azure-sdk-for-go
is updated then we could drop the `replace fix`

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@miekg
Copy link
Member

miekg commented Sep 6, 2019

for reasons I cannot understand, this fails on circle CI:

/home/circleci/.go_workspace/pkg/mod/github.com/!azure/azure-sdk-for-go@v31.1.0+incompatible/services/dns/mgmt/2018-05-01/dns/client.go:24:2: unknown import path "github.com/Azure/go-autorest/autorest": ambiguous import: found github.com/Azure/go-autorest/autorest in multiple modules:
	github.com/Azure/go-autorest v11.1.2+incompatible (/home/circleci/.go_workspace/pkg/mod/github.com/!azure/go-autorest@v11.1.2+incompatible/autorest)
	github.com/Azure/go-autorest/autorest v0.9.0 (/home/circleci/.go_workspace/pkg/mod/github.com/!azure/go-autorest/autorest@v0.9.0)
/home/circleci/.go_workspace/pkg/mod/github.com/!azure/azure-sdk-for-go@v31.1.0+incompatible/services/dns/mgmt/2018-05-01/dns/models.go:24:2: unknown import path "github.com/Azure/go-autorest/autorest/azure": ambiguous import: found github.com/Azure/go-autorest/autorest/azure in multiple modules:
	github.com/Azure/go-autorest v11.1.2+incompatible (/home/circleci/.go_workspace/pkg/mod/github.com/!azure/go-autorest@v11.1.2+incompatible/autorest/azure)
	github.com/Azure/go-autorest/autorest v0.9.0 (/home/circleci/.go_workspace/pkg/mod/github.com/!azure/go-autorest/autorest@v0.9.0/azure)
../../../coredns/plugin/azure/setup.go:14:2: unknown import path "github.com/Azure/go-autorest/autorest/azure/auth": ambiguous import: found github.com/Azure/go-autorest/autorest/azure/auth in multiple modules:
	github.com/Azure/go-autorest v11.1.2+incompatible (/home/circleci/.go_workspace/pkg/mod/github.com/!azure/go-autorest@v11.1.2+incompatible/autorest/azure/auth)
	github.com/Azure/go-autorest/autorest/azure/auth v0.3.0 (/home/circleci/.go_workspace/pkg/mod/github.com/!azure/go-autorest/autorest/azure/auth@v0.3.0)
/home/circleci/.go_workspace/pkg/mod/github.com/!azure/azure-sdk-for-go@v31.1.0+incompatible/services/dns/mgmt/2018-05-01/dns/models.go:25:2: unknown import path "github.com/Azure/go-autorest/autorest/to": ambiguous import: found github.com/Azure/go-autorest/autorest/to in multiple modules:
	github.com/Azure/go-autorest v11.1.2+incompatible (/home/circleci/.go_workspace/pkg/mod/github.com/!azure/go-autorest@v11.1.2+incompatible/autorest/to)
	github.com/Azure/go-autores

@yongtang
Copy link
Member Author

yongtang commented Sep 6, 2019

@miekg Likely coredns/ci has to be updated as well. Let me take another look.

@chrisohaver chrisohaver mentioned this pull request Sep 6, 2019
Merged
@chrisohaver
Copy link
Member

Thanks for cleaning this up @yongtang!

@chrisohaver chrisohaver merged commit e4df752 into master Sep 6, 2019
@corbot corbot bot deleted the go-mod-tidy branch September 6, 2019 16:31
@daxmc99 daxmc99 mentioned this pull request Sep 16, 2019
Merged
@tombuildsstuff tombuildsstuff mentioned this pull request Oct 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisohaver chrisohaver chrisohaver approved these changes

@miekg miekg Awaiting requested review from miekg miekg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yongtang @miekg @chrisohaver