Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MPIArray): property for getting global bounds of local array. #211

Merged
merged 1 commit into from
Aug 17, 2022
Merged

feat(MPIArray): property for getting global bounds of local array. #211

merged 1 commit into from
Aug 17, 2022

Conversation

ljgray
Copy link
Contributor

@ljgray ljgray commented Aug 17, 2022

No description provided.

@ljgray ljgray marked this pull request as ready for review August 17, 2022 22:20
@ljgray ljgray requested a review from jrs65 August 17, 2022 22:20
@ljgray ljgray mentioned this pull request Aug 17, 2022
Merged
jrs65
jrs65 approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@jrs65 jrs65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I'm stoked! We should have done this years ago. One small suggested change to the doc/annotation, but you should decide what you want to do with it and then feel free to merge without another review.

caput/mpiarray.py Outdated Show resolved Hide resolved
@ljgray ljgray merged commit 8ce37f2 into master Aug 17, 2022
@ljgray ljgray deleted the ljg/array-bounds branch August 17, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrs65 jrs65 jrs65 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljgray @jrs65