Parallel RFI filtering #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljgray
force-pushed
the
ljg/parallel-rfi
branch
from
59d9ded
to
7625cf1
Compare
ljgray
requested review from
jrs65 and
tristpinsm
and removed request for
tristpinsm
jrs65
requested changes
Aug 16, 2022
|
Although the products aren't quite right yet, this reduces the |
ljgray
force-pushed
the
ljg/parallel-rfi
branch
4 times, most recently
from
01aa599
to
bba1a5a
Compare
|
Depends on radiocosmology/caput#211 |
ljgray
force-pushed
the
ljg/parallel-rfi
branch
5 times, most recently
from
6b216ed
to
cb8b593
Compare
|
Interestingly, the mask being produced is different from that produced by the previous method. |
|
@jrs65 this produces the same mask now as previous revisions, so it should be good to go unless there are additional changes. |
jrs65
previously approved these changes
Sep 6, 2022
ch_util/rfi.py
Outdated
Comment on lines
598
to
599
| limit_range : slice, optional | ||
| Data is limited to this range in the freqeuncy axis. Defaults to Ellipsis. |
There was a problem hiding this comment.
Maybe change the comment as the default is not actually an Ellipsis (even though it's effectively the same).
There was a problem hiding this comment.
Ah, good catch, that's a remnant of a previous way I had tried implementing it
ljgray
force-pushed
the
ljg/parallel-rfi
branch
from
21a1974
to
e8d8605
Compare
Running number_deviations across inputs causes the entire operation to take place on a single process. This is modified to be distributed across many nodes.
ljgray
force-pushed
the
ljg/parallel-rfi
branch
from
e8d8605
to
2fe5c6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its current implementation, the RFI Filter step of the daily pipeline takes ~25 minutes. Most of this time is spent taking a rolling median, and it is done in a single process. This PR should address the issue by pre-calculating a median across frequencies to flatten the auto vis. data, then distributing across the frequency axis to distribute the computation across processes.