More descriptive exception in WriteShortstr

[tmasternak]

Proposed Changes

This change wraps the ArgumentException throw by Encoding.UTF8.GetBytes when there is not enough space in the output buffer provided. ArgumentException doesn't give any indication on the string value passed to the WriteShortstr which makes it hard for the user to figure out what is the root cause of the problem eg. that the name passed to the DeclareQueue method is too long.

Currently, the exception message is:

The output byte buffer is too small to contain the encoded data, encoding 'Unicode (UTF-8)' fallback
'System.Text.EncoderReplacementFallback'. Parameter name: bytes

With the change the exception message is:

System.ArgumentOutOfRangeException : Value exceeds the maximum allowed length of 255 bytes. Parameter name: val Actual value was value

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

• Bug fix (non-breaking change which fixes issue 6.x client doesn't throw proper exception when input is too long for shortstr #907 )
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)

Checklist

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• All tests pass locally with my changes
• I have added changed tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in related repositories

[pivotal-issuemaster]

@tmasternak Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-issuemaster]

@tmasternak Thank you for signing the Contributor License Agreement!