Merge pull request #908 from tmasternak/master

More descriptive exception in WriteShortstr (cherry picked from commit 19e30bf)
rabbitmq · Jul 10, 2020 · 6d09504 · 6d09504
1 parent 49d60dc
commit 6d09504
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/projects/RabbitMQ.Client/client/impl/WireFormatting.cs b/projects/RabbitMQ.Client/client/impl/WireFormatting.cs
@@ -435,9 +435,17 @@ public static unsafe int WriteShortstr(Span<byte> span, string val)
             fixed (char* chars = val)
             fixed (byte* bytes = &span.Slice(1).GetPinnableReference())
             {
-                int bytesWritten = Encoding.UTF8.GetBytes(chars, val.Length, bytes, maxLength);
-                span[0] = (byte)bytesWritten;
-                return bytesWritten + 1;
+                try
+                {
+                    int bytesWritten = Encoding.UTF8.GetBytes(chars, val.Length, bytes, maxLength);
+                    span[0] = (byte)bytesWritten;
+                    return bytesWritten + 1;
+                }
+                catch (ArgumentException)
+                {
+                    throw new ArgumentOutOfRangeException(nameof(val), val, $"Value exceeds the maximum allowed length of {maxLength} bytes.");
+                }
+
             }
         }
 

diff --git a/projects/Unit/TestFieldTableFormatting.cs b/projects/Unit/TestFieldTableFormatting.cs
@@ -139,7 +139,7 @@ [new string('A', TooLarge)] = null
             int bytesNeeded = WireFormatting.GetTableByteCount(t);
             byte[] bytes = new byte[bytesNeeded];
 
-            Assert.Throws<ArgumentException>(() => WireFormatting.WriteTable(bytes, t));
+            Assert.Throws<ArgumentOutOfRangeException>(() => WireFormatting.WriteTable(bytes, t));
         }
 
         [Test]