Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up to #1434 #1443

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Follow-up to #1434 #1443

merged 1 commit into from
Dec 11, 2023

Conversation

lukebakken
Copy link
Contributor

The original change in #1438 introduced a breaking API change, reported here:

addupsolutions/AddUp.FakeRabbitMQ#189

@lukebakken
Follow-up to #1434
6b804aa 
The original change in #1438 introduced a breaking API change, reported here:

addupsolutions/AddUp.FakeRabbitMQ#189
@lukebakken lukebakken added this to the 6.8.1 milestone Dec 11, 2023
@lukebakken lukebakken self-assigned this Dec 11, 2023
lukebakken added a commit that referenced this pull request Dec 11, 2023
@lukebakken
Port changes from #1443
78d0d97
patrikwlund
patrikwlund approved these changes Dec 11, 2023
View reviewed changes
Copy link

@patrikwlund patrikwlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now! It finds the old constructor instead.

@lukebakken lukebakken marked this pull request as ready for review December 11, 2023 14:35
@lukebakken lukebakken merged commit b3840a9 into 6.x Dec 11, 2023
3 checks passed
@lukebakken lukebakken deleted the rabbitmq-dotnet-client-1434-followup branch December 11, 2023 14:36
lukebakken added a commit that referenced this pull request Dec 11, 2023
@lukebakken
Port #1434 to main
77ed226 
Fixes #1441

Reference:
* #1434
* #1438

Port changes from #1443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrikwlund patrikwlund patrikwlund approved these changes

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
6.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebakken @patrikwlund