-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump RabbitMQ.Client to 6.8.0 #189
Conversation
The RabbitMQ client introduced a breaking API change in a constructor in 6.8.0: rabbitmq/rabbitmq-dotnet-client#1438 So this lib needs to be recompiled against the new version of RabbitMQ to be fully compatible.
Argh, no I didn't realize that change would require re-compilation. I will release 6.8.1 to fix this issue. |
The original change in #1438 introduced a breaking API change, reported here: addupsolutions/AddUp.FakeRabbitMQ#189
@patrikwlund would you mind ensuring that this version does NOT introduce any API changes that require recompilation? |
@lukebakken Looks good now, it finds the correct constructor 👍 |
From what I understand, the 6.8.0 client introduces an unintentional breaking change, but will be fixed back with 6.8.1. I noticed we're still referencing 6.6.0 (and btw wondering why dependabot is not notifying me of these updates...). Shall we depend on 6.8.1 once it's released? I think we should; however, no need to release an updated nuget as nothing will break. |
Oh, found the culprit: AddUp.FakeRabbitMQ/.github/dependabot.yml Lines 9 to 12 in a138bbf
I guess this is by design so that we only upgrade once v7 is released. Therefore, I think it's safest to not depend on v6.8.1 so that we don't force consuming code to be up to date. @patrikwlund what do you think? |
@odalet Correct, our existing nuget will work with 6.8.1. So I think we can keep the current one. No need to force update. |
Thanks for looking into this. Then, I'll close the PR |
FYI, 6.8.1 has officially been released. Thanks @patrikwlund for noticing this quickly and pinging me on it! |
The RabbitMQ client introduced a breaking API change in a
ShutdownEventArgs
constructor in 6.8.0: rabbitmq/rabbitmq-dotnet-client#1438So this lib needs to be recompiled against the new version of RabbitMQ to be fully compatible.
@lukebakken FYI about RabbitMQ.Client 6.8.0. Not sure what the breaking changes policy is, if this is even considered one.