Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RabbitMQ.Client to 6.8.0 #189

Closed
wants to merge 1 commit into from

Conversation

patrikwlund
Copy link

The RabbitMQ client introduced a breaking API change in a ShutdownEventArgs constructor in 6.8.0: rabbitmq/rabbitmq-dotnet-client#1438

So this lib needs to be recompiled against the new version of RabbitMQ to be fully compatible.

@lukebakken FYI about RabbitMQ.Client 6.8.0. Not sure what the breaking changes policy is, if this is even considered one.

The RabbitMQ client introduced a breaking API change in a constructor in 6.8.0:
rabbitmq/rabbitmq-dotnet-client#1438

So this lib needs to be recompiled against the new version of RabbitMQ to be fully compatible.
@lukebakken
Copy link

Argh, no I didn't realize that change would require re-compilation. I will release 6.8.1 to fix this issue.

lukebakken added a commit to rabbitmq/rabbitmq-dotnet-client that referenced this pull request Dec 11, 2023
The original change in #1438 introduced a breaking API change, reported here:

addupsolutions/AddUp.FakeRabbitMQ#189
@lukebakken
Copy link

@patrikwlund would you mind ensuring that this version does NOT introduce any API changes that require recompilation?

https://www.nuget.org/packages/RabbitMQ.Client/6.8.1-rc.1

@patrikwlund
Copy link
Author

@lukebakken Looks good now, it finds the correct constructor 👍

@patrikwlund patrikwlund marked this pull request as draft December 11, 2023 05:01
@odalet
Copy link

odalet commented Dec 11, 2023

From what I understand, the 6.8.0 client introduces an unintentional breaking change, but will be fixed back with 6.8.1.

I noticed we're still referencing 6.6.0 (and btw wondering why dependabot is not notifying me of these updates...). Shall we depend on 6.8.1 once it's released? I think we should; however, no need to release an updated nuget as nothing will break.

@odalet
Copy link

odalet commented Dec 11, 2023

Oh, found the culprit:

ignore:
- dependency-name: RabbitMQ.Client
versions:
- ">= 6.a, < 7"

I guess this is by design so that we only upgrade once v7 is released. Therefore, I think it's safest to not depend on v6.8.1 so that we don't force consuming code to be up to date.

@patrikwlund what do you think?

@patrikwlund
Copy link
Author

@odalet Correct, our existing nuget will work with 6.8.1. So I think we can keep the current one. No need to force update.

@odalet
Copy link

odalet commented Dec 11, 2023

Thanks for looking into this. Then, I'll close the PR

@odalet odalet closed this Dec 11, 2023
@lukebakken
Copy link

FYI, 6.8.1 has officially been released. Thanks @patrikwlund for noticing this quickly and pinging me on it!

@patrikwlund patrikwlund deleted the client-6.8.0 branch December 12, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants