Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tail recursion #1113

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Remove tail recursion #1113

merged 2 commits into from
Apr 17, 2023

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Apr 17, 2023

for better profiles.

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Merging #1113 (35c605d) into main (940010d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 35c605d differs from pull request most recent head 9702a77. Consider uploading reports for the commit 9702a77 to get more accurate results

@@           Coverage Diff           @@
##             main    #1113   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files          46       46           
  Lines        2712     2713    +1     
=======================================
+ Hits         2470     2471    +1     
  Misses        242      242           
Impacted Files Coverage Δ
R/nest.R 100.00% <100.00%> (ø)
R/roxygen-examples-parse.R 96.82% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 940010d is merged into main:

  •   :ballot_box_with_check:cache_applying: 363ms -> 363ms [-1.77%, +1.98%]
  •   :ballot_box_with_check:cache_recording: 1.69s -> 1.68s [-1.45%, +0.78%]
  •   :rocket:without_cache: 3.46s -> 3.43s [-1.87%, -0.12%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit 0f4a215 into main Apr 17, 2023
@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Apr 17, 2023

Thanks @krlmlr :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants