Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split test-public_api for better sharding #1109

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

MichaelChirico
Copy link
Contributor

Closes #1106

No rigorous reasoning behind the split here, just vibes 😎

@codecov-commenter
Copy link

Codecov Report

Merging #1109 (6476b9f) into main (940010d) will not change coverage.
The diff coverage is n/a.

❗ Current head 6476b9f differs from pull request most recent head 6fefe71. Consider uploading reports for the commit 6fefe71 to get more accurate results

@@           Coverage Diff           @@
##             main    #1109   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files          46       46           
  Lines        2712     2712           
=======================================
  Hits         2470     2470           
  Misses        242      242           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lorenzwalthert
Copy link
Collaborator

looks like current {lintr} dev fails on the code now. @MichaelChirico are you aware of that lintr change and is it intentional?

File `R/roxygen-examples-parse.R` is not lint free
Warning: file=/home/runner/work/styler/styler/R/roxygen-examples-parse.R,line=146,col=13,[function_left_parentheses_linter] Left parenthesis should be on the same line as the function's symbol.
Error: File R/roxygen-examples-parse.R is not lint free
Execution halted

Offending expression:

text <- roxygen2::roc_proc_text(
  roxygen2::rd_roclet(),
  paste(roxygen, collapse = "\n")
)[[1L]]$get_section("examples")

@IndrajeetPatil
Copy link
Collaborator

There is already issue about this:

r-lib/lintr#1963

@lorenzwalthert
Copy link
Collaborator

Kirill fixed the pre-commit issue in #1113 .

@lorenzwalthert lorenzwalthert merged commit 0c4187c into r-lib:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Testing] Poor parallelism of test-public_api.R
4 participants