Always use dependency version managed by BOM when forced dependency version is not specified #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run tests |
9 tasks
michalvavrik
commented
Oct 8, 2024
...-test-core/src/main/java/io/quarkus/test/services/quarkus/QuarkusMavenPluginBuildHelper.java
Outdated
Show resolved
Hide resolved
michalvavrik
force-pushed
the
feature/fix-forced-dependency-without-version
branch
from
38d2b2b
to
2942f3f
Compare
michalvavrik
changed the title
|
run tests |
michalvavrik
changed the title
|
I am pretty sure OCP Native failure |
12 tasks
jedla97
added a commit
to jedla97/quarkus-test-framework
that referenced
this pull request
Oct 17, 2024
In case of linux we propagating all build arguments which also contain`s maven.repo.local` This is not case on windows where we getting only specific set of them (starts withQquarkus). when we introduced quarkus-qe#1359 it allow to build the maven separatly with propagated values and causing problems on windows using specific repository with not accesible Quarkus versions
jedla97
added a commit
to jedla97/quarkus-test-framework
that referenced
this pull request
Oct 17, 2024
In case of linux we propagating all build arguments which also contains `maven.repo.local`. This is not case on windows where we getting only specific set of them (starts with Quarkus). When quarkus-qe#1359 was it start to build separatly using maven. But when provided path to local maven repo was set as cmd argument and the artifact is not public, causing the windows failing the build of app with that forced artifact.
jedla97
added a commit
to jedla97/quarkus-test-framework
that referenced
this pull request
Oct 17, 2024
In case of linux we propagating all build arguments which also contains `maven.repo.local`. This is not case on windows where we getting only specific set of them (starts with Quarkus). When quarkus-qe#1359 was introducedThe build start separatly using maven. But when provided path to local maven repo was set as cmd argument and the artifact is not public, causing the windows failing the build of app with that forced artifact.
11 tasks
michalvavrik
pushed a commit
that referenced
this pull request
Oct 17, 2024
In case of linux we propagating all build arguments which also contains `maven.repo.local`. This is not case on windows where we getting only specific set of them (starts with Quarkus). When #1359 was introducedThe build start separatly using maven. But when provided path to local maven repo was set as cmd argument and the artifact is not public, causing the windows failing the build of app with that forced artifact.
jedla97
added a commit
to jedla97/quarkus-test-framework
that referenced
this pull request
Oct 23, 2024
In case of linux we propagating all build arguments which also contains `maven.repo.local`. This is not case on windows where we getting only specific set of them (starts with Quarkus). When quarkus-qe#1359 was introducedThe build start separatly using maven. But when provided path to local maven repo was set as cmd argument and the artifact is not public, causing the windows failing the build of app with that forced artifact. (cherry picked from commit afdcab9)
michalvavrik
pushed a commit
that referenced
this pull request
Oct 23, 2024
In case of linux we propagating all build arguments which also contains `maven.repo.local`. This is not case on windows where we getting only specific set of them (starts with Quarkus). When #1359 was introducedThe build start separatly using maven. But when provided path to local maven repo was set as cmd argument and the artifact is not public, causing the windows failing the build of app with that forced artifact. (cherry picked from commit afdcab9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI in the quarkus-qe/quarkus-test-suite#2072. So far when a dependency version is empty we set there Quarkus version. That I think is less desirable then using managed version and we know that Quarkus extensions are managed by the BOM, so for our use cases shouldn't be breaking change. Additionally, this change allows to use managed version of forced dependencies that are not Quarkus extensions.
Changes in this PR:
I have tested successfully this PR with all the tests that use this feature (
io.quarkus.test.services.QuarkusApplication#dependencies).Please check the relevant options
run testsphrase in comment)Checklist: