Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move brotli4j into test sources and disable it on aarch64 #2072

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Oct 8, 2024

Summary

Move brotli4j sources to test/src, because it breakes other tests on OCP on aarch.

Also disable this test on aarch64, where it is failing because of quarkusio/quarkus#43770

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas marked this pull request as draft October 8, 2024 14:16
@mocenas mocenas changed the title Move brotli4j into test sources Move brotli4j into test sources and disable it on aarch64 Oct 8, 2024
@mocenas
Copy link
Contributor Author

mocenas commented Oct 8, 2024

Using dependencies = @Dependency(groupId = "com.aayushatharva.brotli4j", artifactId = "brotli4j") in code currently requires to also specify version to work. @michalvavrik promised to fixed this in framework.

@michalvavrik
Copy link
Member

Using dependencies = @Dependency(groupId = "com.aayushatharva.brotli4j", artifactId = "brotli4j") in code currently requires to also specify version to work. @michalvavrik promised to fixed this in framework.

quarkus-qe/quarkus-test-framework#1359 :-)

@mocenas mocenas marked this pull request as ready for review October 11, 2024 07:38
@mocenas mocenas merged commit b35c378 into quarkus-qe:main Oct 11, 2024
8 checks passed
@mocenas mocenas deleted the brotli_profile branch October 11, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants