Support TCAV on cuda #725
Closed
Support TCAV on cuda #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NarineK
force-pushed
the
support_tcav_for_cuda
branch
from
322cd81
to
58ea95a
Compare
vivekmig
approved these changes
Aug 16, 2021
| weight_values = torch.FloatTensor(sklearn_model.coef_).to(device) # type: ignore | ||
| bias_values = torch.FloatTensor([sklearn_model.intercept_]).to( # type: ignore | ||
| device # type: ignore | ||
| ) # type: ignore |
There was a problem hiding this comment.
nit: Do we need type: ignore's for all the 3 lines?
There was a problem hiding this comment.
I tried to do for the first or last line but circle CI was complaining and I ended up adding # type: ignore in all three lines.
|
@NarineK has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This was referenced Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issues: #721 #719 #720