Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: TCAV - Concept, specify dataloader yield type #720

Closed
pdpino opened this issue Jul 14, 2021 · 1 comment
Closed

Docs: TCAV - Concept, specify dataloader yield type #720

pdpino opened this issue Jul 14, 2021 · 1 comment

Comments

@pdpino
Copy link

pdpino commented Jul 14, 2021

📚 Documentation

For the captum.concept.Concept class, the docs should state what type of object the data_iter Dataloader must yield. I think it has to yield inputs only (i.e. without labels), by seeing this line from TCAV().
@NarineK NarineK mentioned this issue Jul 21, 2021
Closed
facebook-github-bot pushed a commit that referenced this issue Aug 17, 2021
@NarineK @facebook-github-bot
Support TCAV on cuda (#725)
3a697e3 
Summary:
Addresses the issues: #721 #719 #720

Pull Request resolved: #725

Reviewed By: bilalsal

Differential Revision: D30356015

Pulled By: NarineK

fbshipit-source-id: 010a5263bdfc33e8c4d3f9de523d9d3ba3969f49
@NarineK
Copy link
Contributor

NarineK commented Aug 17, 2021

fixed with #725

@NarineK NarineK closed this as completed Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NarineK @pdpino