Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests from Captum distributions #635

Closed
wants to merge 2 commits into from

Conversation

vivekmig
Copy link
Contributor

Update package exclusion to include tests. Previously tests were included in Captum distributions unnecessarily, outside of the captum package, causing conflicts with other packages.

@vivekmig vivekmig linked an issue Mar 16, 2021 that may be closed by this pull request
@vivekmig vivekmig requested a review from NarineK March 16, 2021 22:27
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivekmig has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivekmig has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@NarineK NarineK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fix!

@facebook-github-bot
Copy link
Contributor

@vivekmig merged this pull request in da53854.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: tests module is included in distribution
3 participants