-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: tests
module is included in distribution
#629
Comments
Thanks for catching this issue @jamesmyatt and the great suggestions! You are right, we were unintentionally distributing this tests module. For now, we have tested a fix to exclude the tests module, which should resolve the issue for future releases. |
@vivekmig , is there any chance of a 0.3.2 release with this fix? |
Hi @jamesmyatt , we are planning to do the 0.4.0 release in the next few weeks, so this fix will be included there. |
Thanks |
Closing this, since 0.4 release it out. |
In conda, I get the following error:
This suggests that this package is distributing a module called
tests
, which is wrong.I assume that the same problem will occur with pip too.
In my experience, the best solution is a
src
layout as described in https://blog.ionelmc.ro/2014/05/25/python-packaging/#the-structure and https://hynek.me/articles/testing-packaging/#src.It's also worth noting that the "tests outside application code" pattern usually doesn't make the
tests
directory into a module: https://docs.pytest.org/en/latest/goodpractices.html?highlight=src#tests-outside-application-code. Note that this good practice guide also strongly suggests a src layout.The text was updated successfully, but these errors were encountered: