Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch tags so hatch-vcs can set the version number #95

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 12, 2023

Follow on from #94.

Also remove the old release job from main.yml.

@hugovk
Copy link
Member Author

hugovk commented Oct 12, 2023

This still isn't extracting the version (e.g. v2.2.0) from the tag (e.g. cherry-picker-v2.2.0).

I'll ask on the #hatch channel of PyPA Discord.

@RonnyPfannschmidt
Copy link

wrong data is due to squash merging - see #96

@hugovk hugovk marked this pull request as ready for review October 13, 2023 15:10
@hugovk
Copy link
Member Author

hugovk commented Oct 13, 2023

Thanks for checking Ronny! So we're all good here.

Deploying via trusted publishing will avoid this in the future.

@hugovk hugovk merged commit cbf5660 into python:main Oct 13, 2023
22 checks passed
@hugovk hugovk deleted the trusted-publisher2 branch October 13, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants