Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squash merge of release branches created sketchy history #96

Closed
RonnyPfannschmidt opened this issue Oct 12, 2023 · 1 comment
Closed

Comments

@RonnyPfannschmidt
Copy link

#89 was squash merged into 1957e38
this means that c028873 which carries the tag via 64b3ffd is not in main

thus leading to a

git describe --tags 
cherry-picker-v2.0.0-45-g38fcdad

on main

@RonnyPfannschmidt RonnyPfannschmidt changed the title squahs merge fo release branches created scetchy history squash merge of release branches created sketchy history Oct 12, 2023
@hugovk
Copy link
Member

hugovk commented Oct 16, 2023

Thanks for the investigation!

We'll be okay in the future because we'll be releasing via GitHub Releases and the tag will be set on main from there.

And I don't think we need to adjust the old tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants