Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions for merging into #161
When manylinux-2014-wheel-build runs, it attempts to pull from githubactions/ubuntu-22.04-jammy-amd64 - https://github.com/python-pillow/docker-images/actions/runs/3392741172/jobs/5650254050#step:5:7
In the case of this repository, incorrectly using "githubactions" because docker isn't logged in for "Test Image Build", only afterwards in "Build image". The simplest solution would to login to docker earlier.
However, when this is running in a forked repository, there is likely no
DOCKER_USERNAME
secret, and the images are not uploaded to Docker Hub. So the test image can't be downloaded from the fork. In that situation, it would seem better to use the pythonpillow test image. Deriving the username from "dockerinfo" doesn't seem simplest when we want to detect if docker is not logged in.So this PR detects the
USERNAME
from the secret directly instead of using "docker info". If that is missing, then it pulls the test image from pythonpillow.