Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test docker image selection #165

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Dec 24, 2022

Suggestions for merging into #161

When manylinux-2014-wheel-build runs, it attempts to pull from githubactions/ubuntu-22.04-jammy-amd64 - https://github.com/python-pillow/docker-images/actions/runs/3392741172/jobs/5650254050#step:5:7

Error response from daemon: pull access denied for githubactions/ubuntu-22.04-jammy-amd64, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

In the case of this repository, incorrectly using "githubactions" because docker isn't logged in for "Test Image Build", only afterwards in "Build image". The simplest solution would to login to docker earlier.

However, when this is running in a forked repository, there is likely no DOCKER_USERNAME secret, and the images are not uploaded to Docker Hub. So the test image can't be downloaded from the fork. In that situation, it would seem better to use the pythonpillow test image. Deriving the username from "dockerinfo" doesn't seem simplest when we want to detect if docker is not logged in.

So this PR detects the USERNAME from the secret directly instead of using "docker info". If that is missing, then it pulls the test image from pythonpillow.

@radarhere radarhere merged commit 4e14725 into python-pillow:manylinux-wheel-updates Jan 7, 2023
@radarhere radarhere deleted the manylinux-wheel-updates branch January 7, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant