Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test target to current Ubuntu #161

Merged
merged 10 commits into from
Jan 9, 2023
Merged

Conversation

wiredfool
Copy link
Member

No description provided.

@radarhere radarhere changed the title Update test target to current ubuntu Update test target to current Ubuntu Nov 3, 2022
wiredfool and others added 2 commits November 3, 2022 21:23
Co-authored-by: Ondrej Baranovič <nulano@nulano.eu>
@radarhere
Copy link
Member

Not quite related question - when I run this branch in my own fork, it fails, saying that it is "Unable to find image 'githubactions/ubuntu-22.04-jammy-amd64:main' locally" (whereas main passes).

Any ideas why that might be?

wiredfool and others added 2 commits November 4, 2022 09:17
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
@wiredfool
Copy link
Member Author

There's a race condition between this image and the test image -- if we're not on main and there isn't a version of it pushed to dockerhub. Because of the branch and username, we're specifically using the test version that's built in this (or your) pr. It might get better on subsequent runs if it's actually pushing to dockerhub, or it won't.

@hugovk
Copy link
Member

hugovk commented Nov 4, 2022

Should this target Python 3.11 by default?

@wiredfool
Copy link
Member Author

No, because Jammy doesn't.

@wiredfool
Copy link
Member Author

guess I'm backing up the CI queue today.

@hugovk
Copy link
Member

hugovk commented Nov 4, 2022

This should help: #162

@wiredfool
Copy link
Member Author

Now I'm just feeling bad for the CO2 burned:
image

Why is this attempting to run 8 times?

@radarhere
Copy link
Member

I don't know where that screenshot comes from, but I really don't think that all of the jobs ran 8 times - I expect it was only one of them that had 8 attempts.

Our test suite has some intermittent failures, but the main culprit is test_redos in test_file_pdf.py. It has a timeout that tends to fail on the slower valgrind job. I tend to rerun the failing job until it passes.

@radarhere radarhere merged commit 2eeede8 into main Jan 9, 2023
@radarhere radarhere deleted the manylinux-wheel-updates branch January 9, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants