Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce ruff as a linter #936

Merged
merged 7 commits into from
Sep 30, 2023
Merged

introduce ruff as a linter #936

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a30746
introduce ruff as a linter
RonnyPfannschmidt Sep 22, 2023
c1b622b
typing extensions always needed
RonnyPfannschmidt Sep 22, 2023
0281efc
move pytest options to pyproject.toml
RonnyPfannschmidt Sep 29, 2023
25aab40
fix check-readme tox target
RonnyPfannschmidt Sep 29, 2023
e967384
add new docs to MANIFEST.in
RonnyPfannschmidt Sep 29, 2023
be35749
setup hatch test envs
RonnyPfannschmidt Sep 29, 2023
57bd901
merge upstream main
RonnyPfannschmidt Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ dependencies = [
"packaging>=20",
"setuptools",
'tomli>=1; python_version < "3.11"',
'typing-extensions; python_version < "3.11"',
"typing-extensions",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"typing extensions always needed"

Can you clarify what this means? I still do not see anywhere that it is needed at runtime, and you appear to have reverted the work from #850 as this is now once again needed at runtime

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree, by the way, that it's not clear the dependencies were correct -- it seems to be unconditionally used, but only at mypy/lint time rather than at runtime. So instead of a versioned dependency, it should have been a test extra.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im happy to make it optional again once i have the time to make sure it works as intended

]
[project.optional-dependencies]
docs = [
Expand Down
Loading