introduce ruff as a linter #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +43,7 @@ dependencies = [ | |||
| "packaging>=20", | |||
| "setuptools", | |||
| 'tomli>=1; python_version < "3.11"', | |||
| 'typing-extensions; python_version < "3.11"', | |||
| "typing-extensions", | |||
There was a problem hiding this comment.
"typing extensions always needed"
Can you clarify what this means? I still do not see anywhere that it is needed at runtime, and you appear to have reverted the work from #850 as this is now once again needed at runtime
There was a problem hiding this comment.
I do agree, by the way, that it's not clear the dependencies were correct -- it seems to be unconditionally used, but only at mypy/lint time rather than at runtime. So instead of a versioned dependency, it should have been a test extra.
There was a problem hiding this comment.
im happy to make it optional again once i have the time to make sure it works as intended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.