Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize MMM plotting methods #822

Open
wd60622 opened this issue Jul 9, 2024 · 0 comments
Open

Standardize MMM plotting methods #822

wd60622 opened this issue Jul 9, 2024 · 0 comments

Comments

@wd60622
Copy link
Contributor

wd60622 commented Jul 9, 2024

What should be required for plotting methods in the MMM? Here are some of my thoughts:

  • method returns a fig, axes where axes is NDArray[plt.Axes] even with one element
  • media transformations plots should allow subseting by channel
  • Ability to pass axes to the plotting method
  • Ability to change the colors of the associated curves

There should be a stand-alone plotting function for methods that will support minimal I/O. For instance, channel contributions should be passed in DataArray instead of a Dataset or InferenceData. The method can extract the necessary information from the DataArray and then call the plotting function. Reference: #821

This would help support other use-cases or general plotting needs that exist outside of the pre-defined MMM classes.

Related to #820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant