Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong type hint for samples in plot_budget_allocation and plot_allocated_contribution_by_channel #821

Closed
wd60622 opened this issue Jul 9, 2024 · 2 comments · Fixed by #873
Closed

Wrong type hint for samples in plot_budget_allocation and plot_allocated_contribution_by_channel #821

wd60622 opened this issue Jul 9, 2024 · 2 comments · Fixed by #873
Labels
docs Improvements or additions to documentation good first issue Good for newcomers MMM

Comments

@wd60622
Copy link
Contributor

wd60622 commented Jul 9, 2024 •
edited

samples is actually Dataset rather than InferenceData

pymc-marketing/pymc_marketing/mmm/delayed_saturated_mmm.py

Lines 2030 to 2032 in d766722

def plot_budget_allocation(
self,
samples: az.InferenceData,

Same here:

pymc-marketing/pymc_marketing/mmm/delayed_saturated_mmm.py

Lines 2129 to 2131 in d766722

def plot_allocated_contribution_by_channel(
self,
samples: az.InferenceData,

@wd60622 wd60622 added docs Improvements or additions to documentation good first issue Good for newcomers MMM labels Jul 9, 2024
@wd60622 wd60622 changed the title Wrong type hint for samples in plot_budget_allocation Wrong type hint for samples in plot_budget_allocation and plot_allocated_contribution_by_channel Jul 9, 2024
@wd60622 wd60622 mentioned this issue Jul 9, 2024
Open
@Ishaanjolly
Copy link
Contributor

hey, I am a newbie, I'd love to contribute to PyMC and have been following for a long time. How can I connect with you to deal with this GitHub issue?

@wd60622
Copy link
Contributor Author

wd60622 commented Jul 24, 2024

hey, I am a newbie, I'd love to contribute to PyMC and have been following for a long time. How can I connect with you to deal with this GitHub issue?

Hi @Ishaanjolly
Thank you for your interest! It'd be great to have this contribution from you
Follow this guide here: https://github.com/pymc-labs/pymc-marketing/blob/main/CONTRIBUTING.md
After the fork and creation of a branch, push it up and open a PR even if it is in early stages so that we can help you and provide feedback

@Ishaanjolly Ishaanjolly mentioned this issue Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Improvements or additions to documentation good first issue Good for newcomers MMM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inference changed to dataset Ishaanjolly/pymc-marketing
2 participants
@wd60622 @Ishaanjolly