Move math out of distribution random methods #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omial random method. The math operations between the distribution parameters was moved to _random, and all parameter broadcasting is handled in generate_samples. Added tests.
twiecki
approved these changes
Jun 7, 2019
|
Thanks @lucianopaz! |
This was referenced Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Triangular,TruncatedNormal,RiceandZeroInflatedNegativeBinomialrandommethod. The math operations between the distribution parameters was moved to_random, and all parameter broadcasting is handled ingenerate_samples.This fixes #3481 and #3508, and supersedes PR #3484.