Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix to issue #3481. #3484

Closed
wants to merge 2 commits into from
Closed

[WIP] Fix to issue #3481. #3484

wants to merge 2 commits into from

Conversation

rpgoldman
Copy link
Contributor

Fix to issue #3481, from @lucianopaz.

@twiecki twiecki requested a review from lucianopaz May 21, 2019 08:45
@lucianopaz
Copy link
Contributor

Thanks @rpgoldman. That's the idea of the fix, but you have to import broadcast_distribution_samples from shape_utils first. I'll try to better explain what causes the issue you saw back on #3481's thread

@twiecki
Copy link
Member

twiecki commented May 22, 2019

Can this be merged?

@twiecki
Copy link
Member

twiecki commented May 22, 2019

Needs a line in release-notes.

@lucianopaz
Copy link
Contributor

I think that to have this ready to merge, we need to at least add a test that proves that issue #3481 is fixed by this (and also add it to the release notes)

@rpgoldman rpgoldman force-pushed the sample-prior-shape-error branch 4 times, most recently from 4b21ff5 to acc6804 Compare May 28, 2019 01:46
@rpgoldman rpgoldman force-pushed the sample-prior-shape-error branch 2 times, most recently from 9d99e2f to eaae7a7 Compare June 3, 2019 20:49
twiecki
twiecki requested changes Jun 6, 2019
View reviewed changes
Copy link
Member

@twiecki twiecki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test and release notes.

@lucianopaz
Copy link
Contributor

@rpgoldman, I took a look at the codebase and found that Triangular, TruncatedNormal, Rice and ZeroInflatedNegativeBinomial suffer from the same error of #3481. I'll make a new issue an PR a fix with tests for all.

@lucianopaz lucianopaz mentioned this pull request Jun 6, 2019
Merged
@lucianopaz
Copy link
Contributor

Superseeded by PR #3509.

@lucianopaz lucianopaz closed this Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twiecki twiecki twiecki requested changes

@lucianopaz lucianopaz Awaiting requested review from lucianopaz

Assignees

@lucianopaz lucianopaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpgoldman @lucianopaz @twiecki