Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks for all set-length-modifying methods in modified-iterating-set #9334

Closed
mdbernard opened this issue Dec 29, 2023 · 0 comments · Fixed by #9333 or #9461
Closed

Add checks for all set-length-modifying methods in modified-iterating-set #9334

mdbernard opened this issue Dec 29, 2023 · 0 comments · Fixed by #9333 or #9461
Assignees
@mdbernard
Labels
Enhancement ✨ Improvement to a component False Negative 🦋 No message is emitted but something is wrong with the code Work in progress
Milestone
3.1.0

Comments

@mdbernard
Copy link
Contributor

Current problem

modified-iterating-set currently only checks for the .add and .remove methods, but not several other length-modifying methods.

Desired solution

Add checks for the .clear, .discard, and .pop methods being called on a set which is being iterated over.

Additional context

No response
@mdbernard mdbernard added the Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling label Dec 29, 2023
mdbernard added a commit to mdbernard/pylint that referenced this issue Dec 29, 2023
@mdbernard
check for all set-length-modifying methods in modified-iterating-set (c…
5860906 
…loses pylint-dev#9334)
mdbernard added a commit to mdbernard/pylint that referenced this issue Dec 29, 2023
@mdbernard
check for all set-length-modifying methods in modified-iterating-set (c…
fecaf6b 
…loses pylint-dev#9334)
@Pierre-Sassoulas Pierre-Sassoulas added Enhancement ✨ Improvement to a component Work in progress False Negative 🦋 No message is emitted but something is wrong with the code and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Dec 29, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.1.0 milestone Dec 29, 2023
@Pierre-Sassoulas Pierre-Sassoulas mentioned this issue Dec 30, 2023
Merged
5 tasks
Pierre-Sassoulas added a commit that referenced this issue Dec 30, 2023
@mdbernard @Pierre-Sassoulas
Check for all set-length-modifying methods in modified-iterating-set (c…
4301129 
…lose #9334) (#9333)

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@Pierre-Sassoulas Pierre-Sassoulas mentioned this issue Feb 25, 2024
Merged
netbsd-srcmastr referenced this issue in NetBSD/pkgsrc Mar 3, 2024
@0-wiz-0
py-pylint: update to 3.1.0.
e20c625 
New Features
------------

- Skip ``consider-using-join`` check for non-empty separators if an ``suggest-join-with-non-empty-separator`` option is set to ``no``.

  Closes #8701 (`#8701 <https://github.com/pylint-dev/pylint/issues/8701>`_)

- Discover ``.pyi`` files when linting.

  These can be ignored with the ``ignore-patterns`` setting.

  Closes #9097 (`#9097 <https://github.com/pylint-dev/pylint/issues/9097>`_)

- Check ``TypeAlias`` and ``TypeVar`` (PEP 695) nodes for ``invalid-name``.

  Refs #9196 (`#9196 <https://github.com/pylint-dev/pylint/issues/9196>`_)

- Support for resolving external toml files named pylintrc.toml and .pylintrc.toml.

  Closes #9228 (`#9228 <https://github.com/pylint-dev/pylint/issues/9228>`_)

- Check for `.clear`, `.discard`, `.pop` and `remove` methods being called on a set while it is being iterated over.

  Closes #9334 (`#9334 <https://github.com/pylint-dev/pylint/issues/9334>`_)



New Checks
----------

- New message `use-yield-from` added to the refactoring checker. This message is emitted when yielding from a loop can be replaced by `yield from`.

  Closes #9229. (`#9229 <https://github.com/pylint-dev/pylint/issues/9229>`_)

- Added a ``deprecated-attribute`` message to check deprecated attributes in the stdlib.

  Closes #8855 (`#8855 <https://github.com/pylint-dev/pylint/issues/8855>`_)


False Positives Fixed
---------------------

- Fixed false positive for ``inherit-non-class`` for generic Protocols.

  Closes #9106 (`#9106 <https://github.com/pylint-dev/pylint/issues/9106>`_)

- Exempt ``TypedDict`` from ``typing_extensions`` from ``too-many-ancestor`` checks.

  Refs #9167 (`#9167 <https://github.com/pylint-dev/pylint/issues/9167>`_)



False Negatives Fixed
---------------------

- Extend broad-exception-raised and broad-exception-caught to except*.

  Closes #8827 (`#8827 <https://github.com/pylint-dev/pylint/issues/8827>`_)

- Fix a false-negative for unnecessary if blocks using a different than expected ordering of arguments.

  Closes #8947. (`#8947 <https://github.com/pylint-dev/pylint/issues/8947>`_)



Other Bug Fixes
---------------

- Improve the message provided for wrong-import-order check.  Instead of the import statement ("import x"), the message now specifies the import that is out of order and which imports should come after it.  As reported in the issue, this is particularly helpful if there are multiple imports on a single line that do not follow the PEP8 convention.

  The message will report imports as follows:
  For "import X", it will report "(standard/third party/first party/local) import X"
  For "import X.Y" and "from X import Y", it will report "(standard/third party/first party/local) import X.Y"
  The import category is specified to provide explanation as to why pylint has issued the message and guidence to the developer on how to fix the problem.

  Closes #8808 (`#8808 <https://github.com/pylint-dev/pylint/issues/8808>`_)



Other Changes
-------------

- Print how many files were checked in verbose mode.

  Closes #8935 (`#8935 <https://github.com/pylint-dev/pylint/issues/8935>`_)

- Fix a crash when an enum class which is also decorated with a ``dataclasses.dataclass`` decorator is defined.

  Closes #9100 (`#9100 <https://github.com/pylint-dev/pylint/issues/9100>`_)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdbernard mdbernard

Labels
Enhancement ✨ Improvement to a component False Negative 🦋 No message is emitted but something is wrong with the code Work in progress
Projects
None yet
Milestone
3.1.0
2 participants
@Pierre-Sassoulas @mdbernard