-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for all set-length-modifying methods in modified-iterating-set (close #9334) #9333
Check for all set-length-modifying methods in modified-iterating-set (close #9334) #9333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution, thank you !
Here's an example of changelog : https://github.com/pylint-dev/pylint/blob/main/doc/whatsnew/fragments/8701.feature (you can refer to this merge request with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9333 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 173 173
Lines 18767 18767
=======================================
Hits 17981 17981
Misses 786 786
|
b907391
to
5860906
Compare
6e8e76d
to
fecaf6b
Compare
for more information, see https://pre-commit.ci
(I made a new issue for this for ease of reference) |
Thank you for your work, very nice first contribution 👍 this is going to be released in 3.1.0, congratulations on becoming a pylint contributor ;) |
Don't hesitate to open multiple PRs if the change requires it. If your review is so
big it requires to actually plan and allocate time to review, it's more likely
that it's going to go stale.
and preferred name in
script/.contributors_aliases.json
Type of Changes
Description
Currently,
modified-iterating-set
only checks for when the.add
or.remove
methods are called on the set being iterated over. However,.clear
,.discard
, and.pop
also raiseRuntimeError
when used on a set while it is being iterated over, so there is value in linting them as well.Closes #9334