Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit autoupdate CI #4906

Merged
merged 1 commit into from
Feb 15, 2021
Merged

pre-commit autoupdate CI #4906

merged 1 commit into from
Feb 15, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Feb 13, 2021 •
edited
Loading

Inspired by the one pandas is using, this adds a workflow which periodically updates the pre-commit hook versions. For a example, see keewis/blackdoc#84

cc @andersy005

andersy005
andersy005 approved these changes Feb 13, 2021
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice!

@keewis keewis merged commit aa5d918 into pydata:master Feb 15, 2021
@keewis keewis deleted the autoupdate-ci branch February 15, 2021 00:20
@mathause
Copy link
Collaborator

Is this going to be a problem when adding CI runs for #4881?

@keewis
Copy link
Collaborator Author

keewis commented Feb 15, 2021 •
edited
Loading

I wouldn't think so: this creates a branch on the main repository and opens a new PR (no auto-merging), so anyone with commit rights can update the PR.

If you worry about the mypy versions we could write a script that compares the version of the pre-commit mypy hook with the ones in the environments and updates the latter, if necessary.

@mathause
Copy link
Collaborator

Yes you are right - let's worry about this once we're there.

dcherian added a commit to dcherian/xarray that referenced this pull request Feb 17, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into dataset/quiver
2b1bc32 
* upstream/master:
  FIX: h5py>=3 string decoding (pydata#4893)
  Update matplotlib's canonical (pydata#4919)
  Adding vectorized indexing docs (pydata#4711)
  Allow fsspec URLs in open_(mf)dataset (pydata#4823)
  Fix typos in example notebooks (pydata#4908)
  pre-commit autoupdate CI (pydata#4906)
  replace the ci-trigger action with a external one (pydata#4905)
  Update area_weighted_temperature.ipynb (pydata#4903)
  hide the decorator from the test traceback (pydata#4900)
  Sort backends (pydata#4886)
  Compatibility with dask 2021.02.0 (pydata#4884)
@keewis keewis mentioned this pull request May 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersy005 andersy005 andersy005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keewis @mathause @andersy005