Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linters are not run after pre-commit autoupdate #5241

Closed
keewis opened this issue May 1, 2021 · 0 comments · Fixed by #5318
Closed

linters are not run after pre-commit autoupdate #5241

keewis opened this issue May 1, 2021 · 0 comments · Fixed by #5318

Comments

@keewis
Copy link
Collaborator

keewis commented May 1, 2021

#4906 added a autoupdate CI for the pre-commit hooks. However, once the hook versions are updated, the pre-commit CI is not run so potential errors will only be visible after merging the PR.

The documentation of create-pr-action states that that's because GITHUB_TOKEN does not allow it to trigger those workflows so we'd have to create a personal access token, or run pre-commit run --all-files immediately after the autoupdate.

The second option is definitely easier but would miss the separate mypy job (not sure how much of an issue that is).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant