Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace the ci-trigger action with a external one #4905

Merged
merged 5 commits into from
Feb 13, 2021
Merged

replace the ci-trigger action with a external one #4905

merged 5 commits into from
Feb 13, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Feb 13, 2021

I think this helps reducing the maintenance burden (I also use this elsewhere). However, it would probably be good to move the action to a different organization (xarray-contrib? pydata?).

  • Passes pre-commit run --all-files

cc @andersy005

@keewis keewis added the CI Continuous Integration tools label Feb 13, 2021
andersy005
andersy005 approved these changes Feb 13, 2021
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, it would probably be good to move the action to a different organization (xarray-contrib? pydata?)

👍🏽 I'm in favor of hosting this under either xarray-contrib or pydata (whichever one is the easiest ...).

@keewis
Copy link
Collaborator Author

keewis commented Feb 13, 2021 •
edited
Loading

xarray-contrib, then: I am able to do the migration there myself.

Edit: done

@keewis keewis merged commit f3f0a14 into pydata:master Feb 13, 2021
@keewis keewis deleted the use-ci-trigger branch February 13, 2021 23:02
dcherian added a commit to dcherian/xarray that referenced this pull request Feb 17, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into dataset/quiver
2b1bc32 
* upstream/master:
  FIX: h5py>=3 string decoding (pydata#4893)
  Update matplotlib's canonical (pydata#4919)
  Adding vectorized indexing docs (pydata#4711)
  Allow fsspec URLs in open_(mf)dataset (pydata#4823)
  Fix typos in example notebooks (pydata#4908)
  pre-commit autoupdate CI (pydata#4906)
  replace the ci-trigger action with a external one (pydata#4905)
  Update area_weighted_temperature.ipynb (pydata#4903)
  hide the decorator from the test traceback (pydata#4900)
  Sort backends (pydata#4886)
  Compatibility with dask 2021.02.0 (pydata#4884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersy005 andersy005 andersy005 approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keewis @andersy005