Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temp_dew mapping in get_psm3 #1920

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

AdamRJensen
Copy link
Member

@AdamRJensen AdamRJensen commented Dec 1, 2023

  • I am familiar with the contributing guidelines
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The dew point column name is currently no mapping correctly when using map_variables=True in get_psm3. The reason is that both words should start with an upper case letter, i.e., "Dew Point" whereas it is currently incorrectly listed as "Dew point" in the VARIABLE_MAP.

@AdamRJensen AdamRJensen added bug io remote-data triggers --remote-data pytests labels Dec 1, 2023
@AdamRJensen AdamRJensen added this to the v0.10.3 milestone Dec 1, 2023
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kandersolar kandersolar merged commit 73cff15 into pvlib:main Dec 1, 2023
30 checks passed
@AdamRJensen AdamRJensen deleted the psm3_dew_point_mapping branch December 1, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug io remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants