Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix temp_dew mapping in get_psm3 #1920

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Fix temp_dew mapping in get_psm3 #1920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8faf76a
Fix temp_dew point mapping
AdamRJensen Dec 1, 2023
0cf1ed4
Add whatsnew entry
AdamRJensen Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/sphinx/source/whatsnew.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ What's New

These are new features and improvements of note in each release.

.. include:: whatsnew/v0.10.3.rst
.. include:: whatsnew/v0.10.2.rst
.. include:: whatsnew/v0.10.1.rst
.. include:: whatsnew/v0.10.0.rst
Expand Down
3 changes: 2 additions & 1 deletion docs/sphinx/source/whatsnew/v0.10.3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ Enhancements

Bug fixes
~~~~~~~~~

* Fix mapping of the dew point column to ``temp_dew`` when ``map_variables``
is True in :py:func:`pvlib.iotools.get_psm3`. (:pull:`1920`)

Testing
~~~~~~~
Expand Down
2 changes: 1 addition & 1 deletion pvlib/iotools/psm3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
'Clearsky DNI': 'dni_clear',
'Solar Zenith Angle': 'solar_zenith',
'Temperature': 'temp_air',
'Dew point': 'temp_dew',
'Dew Point': 'temp_dew',
'Relative Humidity': 'relative_humidity',
'Pressure': 'pressure',
'Wind Speed': 'wind_speed',
Expand Down
2 changes: 1 addition & 1 deletion pvlib/tests/iotools/test_psm3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def test_read_psm3_map_variables():
data, metadata = psm3.read_psm3(MANUAL_TEST_DATA, map_variables=True)
columns_mapped = ['Year', 'Month', 'Day', 'Hour', 'Minute', 'dhi', 'ghi',
'dni', 'ghi_clear', 'dhi_clear', 'dni_clear',
'Cloud Type', 'Dew Point', 'solar_zenith',
'Cloud Type', 'temp_dew', 'solar_zenith',
'Fill Flag', 'albedo', 'wind_speed',
'wind_direction', 'precipitable_water',
'relative_humidity', 'temp_air', 'pressure']
Expand Down
Loading