-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyproject.toml for builds, using setuptools_scm for versioning #36
Comments
Hi Mark, Absolutely, that would be a nice improvement. |
@martin-springer I am working on this on a fork. I am getting a testing error related to https://github.com/markcampanelli/PVDegradationTools/actions/runs/7463413911/job/20308036151 |
I was able to reproduce on the |
@martin-springer I have one issue to sort out before I move this PR out of draft for review. There is apparently not (yet?) a direct way to install a package into a conda environment using its Thus, I'm not sure how this passage in the README should be updated:
I'm inclined to just have folks install |
Thank you, we'll have to update the version in the requirements. |
Yes, that's good with me. We can just focus on using pip for now. We might add support for conda later on. |
@martin-springer Thanks. I will update the READMEs and test installation and running of the notebooks one last time in a fresh Also, for the broken tests, I decided to add a dew-point key "fallback" to try to not force an immediate upgrade |
Hello PVdeg team and thanks for this effort!
I might be able to suggest a significantly more streamlined way of configuring, building, and testing this repo using a
pyproject.toml
file. I just want to check if the team is open to this if I can show that it would work.The text was updated successfully, but these errors were encountered: