Prysm rpc: Get local header #14409
Open
Prysm rpc: Get local header #14409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
requested review from
kasey,
rauljordan and
nisdas
and removed request for
a team
potuz
requested changes
Sep 2, 2024
| return nil, status.Errorf(codes.FailedPrecondition, "EPBS fork has not occurred yet") | ||
| } | ||
|
|
||
| st, parentRoot, err := vs.getParentState(ctx, slot) |
There was a problem hiding this comment.
This is not good enough, this path will get the parent state from the blockroot without caring for full vs empty. I am not sure how to proceed, while this would be outside of the scope of this PR, I feel like merging this right now may turn out to surface subtle bugs later.
| } | ||
|
|
||
| proposerIndex := req.ProposerIndex | ||
| localPayload, err := vs.getLocalPayloadFromEngine(ctx, st, parentRoot, slot, proposerIndex) |
There was a problem hiding this comment.
This function is still not compatible with ePBS, it doesn't handle the fork
terencechain
force-pushed
the
get-local-header-1
branch
from
e37fe64
to
9ec23e3
Compare
terencechain
force-pushed
the
get-local-header-1
branch
from
9ec23e3
to
3471b7f
Compare
terencechain
force-pushed
the
get-local-header-1
branch
from
3471b7f
to
e88900f
Compare
This implements a helper to get the ptc committee from a state. It uses the cached beacon committees if possible It also implements a helper to compute the largest power of two of a uint64 and a helper to test for nil payload attestation messages
* Add ePBS to db
* Signed execution payload header for sync * Use RO state * SignedExecutionPayloadHeader by hash and root * Fix execution headers cache
* Handle incoming ptc attestation messages in the chain package * fix double import * remove unused error
Add wait until PTC duty
potuz
force-pushed
the
epbs
branch
2 times, most recently
from
7cb2381
to
0eb509b
Compare
terencechain
force-pushed
the
get-local-header-1
branch
from
e88900f
to
c07eb89
Compare
terencechain
force-pushed
the
get-local-header-1
branch
from
c07eb89
to
00b32da
Compare
potuz
force-pushed
the
epbs
branch
3 times, most recently
from
fd37f28
to
f30c97a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Prysm RPC endpoint to retrieve the local header for the proposer to sign. The
getLocalHeadercall uses the existinggetLocalPayloadFromEnginemethod and the input slot and proposer index to obtain the payload from the execution client.This PR does not include caching the payload, we should implement caching once the end-to-end process is more defined, so we have a clearer understanding of what the cache's API will look like.