Prysm rpc: Get payload attestation data #14380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
requested review from
kasey,
rauljordan and
rkapka
and removed request for
a team
terencechain
force-pushed
the
get-payload-attestation
branch
2 times, most recently
from
c45122b
to
7ec63f4
Compare
terencechain
force-pushed
the
get-payload-attestation
branch
3 times, most recently
from
74d9c84
to
019fb8f
Compare
terencechain
force-pushed
the
get-payload-attestation
branch
from
019fb8f
to
7fa87b9
Compare
terencechain
commented
Sep 9, 2024
| @@ -544,12 +545,6 @@ func (s *Service) recoverStateSummary(ctx context.Context, blockRoot [32]byte) ( | |||
| return nil, errBlockDoesNotExist | |||
| } | |||
|
|
|||
| // PayloadBeingSynced returns whether the payload for the block with the given | |||
| // root is currently being synced and what is the withheld status in the payload | |||
| func (s *Service) PayloadBeingSynced(root [32]byte) (primitives.PTCStatus, bool) { | |||
There was a problem hiding this comment.
No longer used by external services. It is better not to have to export it if we can
potuz
pushed a commit
that referenced
this pull request
Sep 13, 2024
potuz
pushed a commit
that referenced
this pull request
Sep 18, 2024
potuz
pushed a commit
that referenced
this pull request
Sep 26, 2024
potuz
pushed a commit
that referenced
this pull request
Oct 7, 2024
potuz
pushed a commit
that referenced
this pull request
Oct 14, 2024
potuz
pushed a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the retrieval of payload attestation data.
We also modified
HighestReceivedBlockSlottoHighestReceivedBlockSlotRoot, which also returns the slot + root. I couldn't find a good compromise to retrieve a root for a given slot without accessing the DB. After considering various options, I believeHighestReceivedBlockSlotRootis the best change.