Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The change of "json-module" #856

Closed
yejinjian opened this issue Jul 5, 2017 · 1 comment
Closed

The change of "json-module" #856

yejinjian opened this issue Jul 5, 2017 · 1 comment

Comments

@yejinjian
Copy link

the change commit

why "json-module" default use " protobuf/minimal "?
"protobuf/minimal" did not have function "Root()"
@dcodeIO
Copy link
Member

dcodeIO commented Jul 11, 2017

Related: #860

@eventualbuddha eventualbuddha mentioned this issue Jul 11, 2017
Merged
@dcodeIO dcodeIO closed this as completed Jul 11, 2017
Szpadel pushed a commit to Szpadel/protobuf.js that referenced this issue Jul 25, 2017
@eventualbuddha @Szpadel
Fixed dependency for json-module to use "light".
4a40e53 
"minimal" doesn't include `Root`, as mentioned in protobufjs#828 and protobufjs#856. Probably caused by protobufjs#813.
ccdunder pushed a commit to ccdunder/protobuf.js that referenced this issue Nov 27, 2017
@eventualbuddha @ccdunder
Fixed dependency for json-module to use "light".
1b21511 
"minimal" doesn't include `Root`, as mentioned in protobufjs#828 and protobufjs#856. Probably caused by protobufjs#813.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcodeIO @yejinjian