-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Has json-module with reflection changed since 6.8? #828
Comments
There have been a couple of changes along the road, but without additional context from your generated file it's hard to tell. |
Wow thanks for the prompt reply. Here is the header part of the generated
Here is the same header part generated using protobufjs 6.7.3:
|
Ah, for some reason this is now including the minimal library, which doesn't include reflection at all (so no Could be related to #813 Ideally, it should be |
Yep, a comparison made it clear. The |
Also that I have the following errors if I change the Suppose I have a type from reflection lookup:
It complains
|
const a = CustomT.fromObject(other);
const decodedMessage = CustomT.decode(buffer);
CustomT.toObject(decodedMessage , {defaults: true}); |
Thanks for the quick update! |
When you remove methods from your public API, that is a breaking change, and warrants a major version bump. The current version should be 7.0.0, not 6.8.0. It would be nice to give a release or two with a deprecation notice before removing methods. |
See also, note at https://github.com/dcodeIO/protobuf.js#nodejs |
"minimal" doesn't include `Root`, as mentioned in protobufjs#828 and protobufjs#856. Probably caused by protobufjs#813.
"minimal" doesn't include `Root`, as mentioned in protobufjs#828 and protobufjs#856. Probably caused by protobufjs#813.
protobuf.js version: 6.8
I have been using protobuf.js to generate json-module with reflection information, it's been working fine until 6.7.3 and a recent upgrade to 6.8 is throwing errors.
For example I use the following command to generate json-module:
The errors:
Thanks!!
The text was updated successfully, but these errors were encountered: