Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin kombu so dependabot can update dependencies without breaking everything #4608

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Aug 2, 2023

Jira Ticket

COST-####

Description

This change will ...

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Notes

...

@maskarb maskarb requested review from a team as code owners August 2, 2023 13:12
@maskarb maskarb added the smoke-tests pr_check will build the image and run minimal required smokes label Aug 2, 2023
@samdoran samdoran changed the title pin kombu so dependabot can update dependencies without breaking ever… Pin kombu so dependabot can update dependencies without breaking everything Aug 2, 2023
@samdoran
Copy link
Contributor

samdoran commented Aug 2, 2023

samdoran
samdoran previously approved these changes Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #4608 (9866e12) into main (42962d3) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #4608     +/-   ##
=======================================
- Coverage   93.8%   93.8%   -0.0%     
=======================================
  Files        372     372             
  Lines      30036   30036             
  Branches    3526    3526             
=======================================
- Hits       28180   28173      -7     
- Misses      1197    1203      +6     
- Partials     659     660      +1     

@maskarb maskarb removed the smoke-tests pr_check will build the image and run minimal required smokes label Aug 2, 2023
@maskarb maskarb enabled auto-merge (squash) August 2, 2023 15:53
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@maskarb maskarb added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label Aug 2, 2023
@maskarb
Copy link
Member Author

maskarb commented Aug 2, 2023

/retest

@maskarb maskarb merged commit c9ef539 into main Aug 2, 2023
10 checks passed
@maskarb maskarb deleted the pin-kombu-for-now branch August 2, 2023 17:45
maskarb added a commit that referenced this pull request Aug 9, 2023
…ything (#4608)

* pin kombu so dependabot can update dependencies without breaking everything

* update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants