Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain kombu #4544

Closed
wants to merge 1 commit into from
Closed

Constrain kombu #4544

wants to merge 1 commit into from

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Jul 6, 2023

Description

Kombu 5.3 fixed bugs that incorrectly cast UUID and datetime objects to strings. We expect those to be strings in many places.

celery/kombu#1575
celery/kombu#1515
https://github.com/celery/kombu/releases/tag/v5.3.0

Closes #4539.

@samdoran samdoran added the smoke-tests pr_check will build the image and run minimal required smokes label Jul 6, 2023
@samdoran samdoran requested review from a team as code owners July 6, 2023 17:19
Kombu 5.3 fixed bugs that incorrectly cast UUID and datetime objects to
strings. We expect those to be strings in many places.

celery/kombu#1575
celery/kombu#1515
https://github.com/celery/kombu/releases/tag/v5.3.0
@maskarb
Copy link
Member

maskarb commented Jul 6, 2023

I think we should update kombu instead. That is why this was opened:
https://issues.redhat.com/browse/COST-3997.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #4544 (eee163b) into main (361fbf5) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #4544     +/-   ##
=======================================
- Coverage   93.8%   93.8%   -0.0%     
=======================================
  Files        368     368             
  Lines      29563   29563             
  Branches    3461    3461             
=======================================
- Hits       27733   27731      -2     
- Misses      1184    1185      +1     
- Partials     646     647      +1     

@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants