Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Header examples that still used deprecated system props #3201

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Fix Header examples that still used deprecated system props #3201

merged 2 commits into from
Apr 21, 2023

Conversation

allyjweir
Copy link
Contributor

@allyjweir allyjweir commented Apr 20, 2023 •
edited
Loading

Remove deprecated use of mr system prop, instead using sx.

Related PR: #1336

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@allyjweir
Update Header.mdx
a7b6aab 
Remove deprecated use of `mr` system prop, instead using `sx`.

Related PR: primer#1336
@allyjweir allyjweir requested review from a team and siddharthkp April 20, 2023 08:47
@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2807b7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@allyjweir
Copy link
Contributor Author

allyjweir commented Apr 20, 2023 •
edited
Loading

Hi there, given this is a docs change only, what should I complete re: the merge checklist?

Thanks!

@allyjweir allyjweir temporarily deployed to github-pages April 20, 2023 08:55 — with GitHub Actions Inactive
josepmartins
josepmartins approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@josepmartins josepmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGMT ❇️

@joshblack joshblack added the skip changeset This change does not need a changelog label Apr 21, 2023
@joshblack joshblack added the docs Documentation label Apr 21, 2023
@joshblack joshblack added this pull request to the merge queue Apr 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 21, 2023
@joshblack joshblack added this pull request to the merge queue Apr 21, 2023
Merged via the queue into primer:main with commit ee33b02 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josepmartins josepmartins josepmartins approved these changes

@joshblack joshblack joshblack approved these changes

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

Assignees
No one assigned
Labels
docs Documentation skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allyjweir @josepmartins @joshblack