Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate system props, but don't remove system props #1336

Merged
merged 16 commits into from
Jul 22, 2021

Conversation

VanAnderson
Copy link
Contributor

This PR deprecates system props in all components except Box, but does not actually remove them. A codemod with documentation is provided to enable users to easily make the transition.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2021

🦋 Changeset detected

Latest commit: b4b0d1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/8vinz2DFD83h5KTft9VC1ixCyTDb
✅ Preview: https://primer-components-git-vananderson-deprecate-system-props-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview July 21, 2021 22:32 Inactive
@vercel vercel bot temporarily deployed to Preview July 21, 2021 22:41 Inactive
@vercel vercel bot temporarily deployed to Preview July 21, 2021 23:20 Inactive
@VanAnderson VanAnderson marked this pull request as ready for review July 21, 2021 23:27
@VanAnderson
Copy link
Contributor Author

Much more tweaking on the codemod here, we should be to the place where running it on a production codebase like memex will only take about 15 minutes give or take of post codemod tweaking to get things right. 👍

@vercel vercel bot temporarily deployed to Preview July 21, 2021 23:31 Inactive
@vercel vercel bot temporarily deployed to Preview July 22, 2021 19:44 Inactive
@vercel vercel bot temporarily deployed to Preview July 22, 2021 19:48 Inactive
@vercel vercel bot temporarily deployed to Preview July 22, 2021 20:03 Inactive
@vercel vercel bot temporarily deployed to Preview July 22, 2021 21:06 Inactive
@vercel vercel bot temporarily deployed to Preview July 22, 2021 21:12 Inactive
@vercel vercel bot temporarily deployed to Preview July 22, 2021 21:22 Inactive
@vercel vercel bot temporarily deployed to Preview July 22, 2021 21:27 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colebemis colebemis merged commit 489a718 into main Jul 22, 2021
@colebemis colebemis deleted the VanAnderson/deprecate-system-props branch July 22, 2021 21:32
@github-actions github-actions bot mentioned this pull request Jul 22, 2021
allyjweir added a commit to allyjweir/react that referenced this pull request Apr 20, 2023
Remove deprecated use of `mr` system prop, instead using `sx`.

Related PR: primer#1336
joshblack added a commit that referenced this pull request Apr 21, 2023
Remove deprecated use of `mr` system prop, instead using `sx`.

Related PR: #1336

Co-authored-by: Josh Black <joshblack@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants