-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #760
Spelling #760
Changes from 8 commits
0b71b77
d4d07d2
0f3eb3a
892e5b2
84996fe
86ac1d6
1683b94
6656bc2
4ab7155
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ The octicons node.js library is the main JavaScript library. With [a JavaScript | |
|
||
| Package | Version | | ||
| ------------------------------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------- | | ||
| **[@primer/octicons](/lib/octicons_node)** <br />Node.js package with Javascript API | [![npm version](https://img.shields.io/npm/v/@primer/octicons.svg)](https://www.npmjs.org/package/@primer/octicons) | | ||
| **[@primer/octicons](/lib/octicons_node)** <br />Node.js package with JavaScript API | [![npm version](https://img.shields.io/npm/v/@primer/octicons.svg)](https://www.npmjs.org/package/@primer/octicons) | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This (brand item) is flagged by a distinct check that is still fairly experimental. |
||
| **[@primer/octicons-react](/lib/octicons_react)** <br />React Octicons components | [![npm version](https://img.shields.io/npm/v/@primer/octicons-react.svg)](https://www.npmjs.org/package/@primer/octicons-react) | | ||
| **[@primer/styled-octicons](/lib/octicons_styled)** <br />React Octicons components with Styled System props | [![npm version](https://img.shields.io/npm/v/@primer/styled-octicons.svg)](https://www.npmjs.org/package/@primer/styled-octicons) | | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,10 +65,10 @@ export default function IconViewer({children}) { | |
function gridGradient(angle, size, color) { | ||
// WebKit browsers do not support the "transparent" keyword in gradients. | ||
// As a workaround, we convert `color` to rgba with an alpha value of 0. | ||
const tranparent = rgba(color, 0) | ||
return `linear-gradient(${angle}deg, ${tranparent}, ${tranparent} ${Math.floor( | ||
const transparent = rgba(color, 0) | ||
return `linear-gradient(${angle}deg, ${transparent}, ${transparent} ${Math.floor( | ||
size / 2 | ||
)}px, ${color}, ${tranparent} ${Math.floor(size / 2) + 1}px)` | ||
)}px, ${color}, ${transparent} ${Math.floor(size / 2) + 1}px)` | ||
Comment on lines
-68
to
+71
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While the comment appears to be suggesting that WebKit browsers wouldn't like seeing |
||
} | ||
|
||
function getGridSize(zoom) { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,7 +90,7 @@ | |
"git-pull-request": ["review"], | ||
"github-action": ["board", "workflow", "action", "automation"], | ||
"globe": ["world", "earth", "planet"], | ||
"grabber": ["mover", "drap", "drop", "sort"], | ||
"grabber": ["mover", "drag", "drop", "sort"], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is probably the scariest change. |
||
"graph": ["trend", "stats", "statistics"], | ||
"heart": ["love", "beat"], | ||
"heart-outline": ["love", "beat"], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've excluded this file from checks because the other two items in it were reports of corrections to misspellings.
This item doesn't appear to be intentional.