Spelling #760
Spelling #760
Conversation
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
|
| - We've given Octicons a new look ✨ Some icons have new names and some icons haven't been redesigned yet. The following table documents those changes. If you're using an octicon in v9.x that doesn't have an equivelent in v10.0 yet, let us know by [opening an issue](https://github.com/primer/octicons/issues/new?assignees=&labels=icon+request&template=icon-request.md&title=%5BIcon+request%5D). | ||
| - We've given Octicons a new look ✨ Some icons have new names and some icons haven't been redesigned yet. The following table documents those changes. If you're using an octicon in v9.x that doesn't have an equivalent in v10.0 yet, let us know by [opening an issue](https://github.com/primer/octicons/issues/new?assignees=&labels=icon+request&template=icon-request.md&title=%5BIcon+request%5D). |
There was a problem hiding this comment.
I've excluded this file from checks because the other two items in it were reports of corrections to misspellings.
This item doesn't appear to be intentional.
| | **[@primer/octicons](/lib/octicons_node)** <br />Node.js package with Javascript API | [](https://www.npmjs.org/package/@primer/octicons) | | ||
| | **[@primer/octicons](/lib/octicons_node)** <br />Node.js package with JavaScript API | [](https://www.npmjs.org/package/@primer/octicons) | |
There was a problem hiding this comment.
This (brand item) is flagged by a distinct check that is still fairly experimental.
| const tranparent = rgba(color, 0) | ||
| return `linear-gradient(${angle}deg, ${tranparent}, ${tranparent} ${Math.floor( | ||
| const transparent = rgba(color, 0) | ||
| return `linear-gradient(${angle}deg, ${transparent}, ${transparent} ${Math.floor( | ||
| size / 2 | ||
| )}px, ${color}, ${tranparent} ${Math.floor(size / 2) + 1}px)` | ||
| )}px, ${color}, ${transparent} ${Math.floor(size / 2) + 1}px)` |
There was a problem hiding this comment.
While the comment appears to be suggesting that WebKit browsers wouldn't like seeing transparent in CSS, I don't think it's saying that they'd object to it in JavaScript.
| "grabber": ["mover", "drap", "drop", "sort"], | ||
| "grabber": ["mover", "drag", "drop", "sort"], |
There was a problem hiding this comment.
This is probably the scariest change.
|
@jsoref Thank you so much for this contribution! I have assigned @colebemis to review this since this has some changes to our codebase. |
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@5f4b8a9#commitcomment-67548952
The action reports that the changes in this PR would make it happy: jsoref@86e02c6
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.