Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise stackgl bundle and add test against undesirable direct changes to stackgl_modules/index.js #6937

Merged
merged 5 commits into from
Mar 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,25 @@ jobs:
name: Display function constructors in all bundles
command: npm run no-new-func

test-stackgl-bundle:
docker:
- image: cimg/node:16.17.1
working_directory: ~/plotly.js
steps:
- checkout
- run:
name: Set up build environment
command: cd stackgl_modules && npm ci
- run:
name: Bundle bundle-stackgl/index.js
command: cd stackgl_modules && cp index.js INDEX.js && npm run bundle-stackgl
- run:
name: Test stackgl_modules/index.js diff - If failed please remember this file in auto generated and you should not modify it directly until a dependeny change. To suggest changes please submit pull request to the relevant dependency.
command: diff --unified --color stackgl_modules/INDEX.js stackgl_modules/index.js
- store_artifacts:
path: stackgl_modules/index.js
destination: stackgl_modules/index.js

workflows:
version: 2
build-and-test:
Expand Down Expand Up @@ -565,3 +584,5 @@ workflows:
- install-and-cibuild

- publish-dist

- test-stackgl-bundle
1 change: 1 addition & 0 deletions draftlogs/6937_change.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Regenerate `stackgl_modules/index.js` using updated dependencies [[#6937](https://github.com/plotly/plotly.js/pull/6937)]
Loading