Revise stackgl bundle and add test against undesirable direct changes to stackgl_modules/index.js
#6937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
commented
Mar 20, 2024
| /******/ var __webpack_modules__ = ({ | ||
|
|
||
| /***/ 7386: | ||
| /***/ 1964: |
archmoj
commented
Mar 20, 2024
| @@ -1,43 +1,33 @@ | |||
| (function webpackUniversalModuleDefinition(root, factory) { | |||
There was a problem hiding this comment.
The umd header is not required.
It is now simplified to a commonjs module.
archmoj
commented
Mar 20, 2024
| "ify-loader": "1.1.0", | ||
| "node-polyfill-webpack-plugin": "3.0.0", | ||
| "webpack": "5.90.3", | ||
| "webpack-cli": "5.1.4" |
There was a problem hiding this comment.
I also pinned down these version to avoid potential changes to the bundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update was important so that switching to
esbuildin near future does not break the stackgl bundling task.Also a test is added which would be helpful for reviewers and developers when working on changes of stackgl modules e.g. to address #3613.
cc: @plotly/plotly_js