Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use probe-image-size module to read width and height of images #5388

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Use probe-image-size module to read width and height of images #5388

merged 1 commit into from
Jan 8, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 8, 2021

Addressing #5377 (comment),
this should close #5243 and #5377 plus it may be useful for #1323.

@plotly/plotly_js
@rreusser

@archmoj archmoj added this to the Next major milestone Jan 8, 2021
alexcjohnson
alexcjohnson approved these changes Jan 8, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Nice and easy 🥇

@archmoj archmoj merged commit c7e5a22 into master Jan 8, 2021
@archmoj archmoj deleted the switch-to-probe-image-size branch January 8, 2021 13:58
This was referenced Jan 8, 2021
Closed
Closed
@archmoj archmoj mentioned this pull request May 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
status: reviewable type: bug
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

ReferenceError: document is not defined
2 participants
@archmoj @alexcjohnson