Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pluggable grid framework #264

Merged
merged 1 commit into from
Sep 7, 2016
Merged

Remove pluggable grid framework #264

merged 1 commit into from
Sep 7, 2016

Conversation

agitator
Copy link
Member

@agitator agitator commented Sep 6, 2016

closes #231

@datakurre
Copy link
Member

datakurre commented Sep 6, 2016 •
edited by agitator
Loading

@agitator, TODO

  • remove removal of bin/* files from this pull (those are required by Heroku-button)
  • upgrade step for registering new bundle
  • remove data-gridsystem and data-grid attributes from https://github.com/plone/plone.app.mosaic/tree/master/src/plone/app/mosaic/layouts and replace data-grid attributes with Mosaic or Barceloneta grid class names
  • remove data-grid-attribute-creation from $.mosaic.getPageContent (mosaic.layout.js)
  • document how to apply to your own gridsystem

datakurre
datakurre reviewed Sep 7, 2016
View reviewed changes
src/plone/app/mosaic/transform.py
# settings, 'default_grid_system', None) or None
# if gridSystem is None:
# body_classes.append('mosaic-grid')
body_classes.append('mosaic-grid')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agitator This should be unnecessary now and could also be removed (not only commented out).

@vangheem vangheem force-pushed the datakurre-barceloneta-grid branch 2 times, most recently from 5923c89 to cf91cee Compare September 7, 2016 10:51
@vangheem vangheem merged commit 16aeb06 into master Sep 7, 2016
@vangheem vangheem deleted the datakurre-barceloneta-grid branch September 7, 2016 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove pluggable grid framework
3 participants
@agitator @datakurre @vangheem